Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports example in README.md #190

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

isnifer
Copy link
Contributor

@isnifer isnifer commented Oct 10, 2024

Since signature of exports has changed in 1.0.0 it requires to change import statement in modern code bases

@j0k3r
Copy link

j0k3r commented Oct 17, 2024

Maybe you should rebase against the master to fix the build.

But this should definitely got merged and maybe the 1.0.0 release note should mention that change as well.

@blakeembrey blakeembrey merged commit 408c2b4 into jshttp:master Oct 18, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants